← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2115952] Re: [OVN][QoS] Allow max-bw only QoS policies to use the OVN policer

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/954137
Committed: https://opendev.org/openstack/neutron/commit/4ebd69f2c5456d8f3a357eefac1e07c46c54fea3
Submitter: "Zuul (22348)"
Branch:    master

commit 4ebd69f2c5456d8f3a357eefac1e07c46c54fea3
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Fri Jul 4 14:17:18 2025 +0000

    Use the OVN policer for max-bw only QoS policies
    
    As reported in the related bug, when [1] was implemented, that
    introduced a regression when a port located in a physical network,
    with maximum bandwidth *only* QoS rules and egress direction, was
    bound to a compute node with a bond interface on the physical network
    bridge. The TC commands have no effect on the interfaces of the bond.
    
    This patch restores the backend enforcement for this scenario (physical
    networks, egress direction, maximum bandwidth rule only) to the OVN
    policer, using the OVN ``QoS`` registers, instead of relying on the
    physical interface bandwidth enforcement, using TC commands.
    
    [1]https://review.opendev.org/c/openstack/neutron/+/934418
    
    Closes-Bug: #2115952
    Signed-off-by: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
    Change-Id: I7bf4dc396a044d0d67d2d2f6e68140c063f3e3d8


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2115952

Title:
  [OVN][QoS] Allow max-bw only QoS policies to use the OVN policer

Status in neutron:
  Fix Released

Bug description:
  Since [1], the enforcement of the QoS rules in a port located in a
  physical network (VLAN, flat) and egress rules, is done in the
  physical interface of the physical network bridge.

  That patch allowed to have min-bw rules in ML2/OVS. However, that
  introduces a regression in some scenarios. For example, when max-bw
  *only* QoS policies are used and the physical bridge is connected to a
  bond interface. In this case, OVS cannot apply the TC commands to the
  multiple interfaces that participate in the bond.

  The goal of this bug is to partially revert this behaviour. If we have
  QoS policies with max-bw only (it is important this observation, the
  QoS policy must have only max-bw rules), the ML2/OVS extension should
  use the OVN policer to enforce the BW limit.

  I'm setting the importance to "medium", because this is indeed a bug
  (regression) but for a very specific scenario.

  [1]https://review.opendev.org/c/openstack/neutron/+/934418

  Jira reference: https://issues.redhat.com/browse/OSPRH-18010

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2115952/+subscriptions



References