← Back to team overview

yahoo-eng-team team mailing list archive

  1. yahoo-eng-team team
  2. Mailing list archive
  3. Message #96196

[Bug 2117477] [NEW] [unmaintained-only] unknown keyword flow_group_id

  Thread Previous • Date Previous • • Thread Next 
Public bug reported:

I made a mistake in the backport of Ia61784174ee610b338f26660b2954330abc131a1.
This bug tracks the fix for that mistake.
Only unmaintained branches are affected.

Earlier I backported this change:
Ia61784174ee610b338f26660b2954330abc131a1 Add a default goto table=94 for openvswitch fw

So today Ia61784174ee610b338f26660b2954330abc131a1 is merged on these branches:
master
stable/2025.1
stable/2024.2
stable/2024.1
unmaintained/2023.1
unmaintained/zed
unmaintained/yoga
unmaintained/xena
unmaintained/wallaby
unmaintained/victoria

Ia61784174ee610b338f26660b2954330abc131a1 uses 'flow_group_id', therefore it depends on this change:
If4984dece266a789d607725f8497f1aac3d73d23 Allow to process FW OF rules belonging to a port in a single operation

In my earlier backports I did not notice this dependency.

Today If4984dece266a789d607725f8497f1aac3d73d23 is merged only on these branches:
master
stable/2025.1
stable/2024.2
stable/2024.1
unmaintained/2023.1
unmaintained/zed

Therefore we have some old branches, where Ia61784174ee610b338f26660b2954330abc131a1 is merged but its dependency If4984dece266a789d607725f8497f1aac3d73d23 is not:
unmaintained/yoga
unmaintained/xena
unmaintained/wallaby
unmaintained/victoria

Just to double check, zed seems ok, but older branches are not:
ack --ignore-dir=neutron/tests -l flow_group_id neutron
unmaintained/zed
  neutron/agent/linux/openvswitch_firewall/firewall.py
  neutron/agent/common/ovs_lib.py
unmaintained/yoga
  neutron/agent/linux/openvswitch_firewall/firewall.py
unmaintained/xena
  neutron/agent/linux/openvswitch_firewall/firewall.py
unmaintained/wallaby
  neutron/agent/linux/openvswitch_firewall/firewall.py
unmaintained/victoria                                                                                                                                                                                                                          
  neutron/agent/linux/openvswitch_firewall/firewall.py

On the problematic branches we do not handle flow_group_id, therefore it
reaches ovs, that reports not knowing flow_group_id:

2025-07-16T15:00:20.810204+02:00 compute2.cee.tld neutron-openvswitch-agent[113904]: neutron.agent.linux.utils - ERROR - Exit code: 1; Cmd: ['ovs-ofctl', 'add-flows', '-O', 'OpenFlow10', 'br-int', '--bundle', '-']; Stdin: hard_timeout=0,idle_timeout=0,priority=100,table=60,in_port=12,cookie=3266576298366935998,actions=set_field:12->reg5,set_field:9->reg6,resubmit(,73)
hard_timeout=0,idle_timeout=0,priority=80,table=73,reg5=12,cookie=3266576298366935998,actions=resubmit(,94)
hard_timeout=0,idle_timeout=0,priority=12,table=94,dl_dst=fa:16:3e:54:6a:83,reg6=9,cookie=3266576298366935998,actions=output:12
hard_timeout=0,idle_timeout=0,priority=12,flow_group_id=12,table=94,dl_dst=fa:16:3e:54:6a:83,dl_vlan=9,cookie=3266576298366935998,actions=strip_vlan,output:12
hard_timeout=0,idle_timeout=0,priority=10,table=94,dl_src=fa:16:3e:54:6a:83,dl_dst=00:00:00:00:00:00/01:00:00:00:00:00,reg6=9,cookie=3266576298366935998,actions=mod_vlan_vid:9,output:1; Stdout: ; Stderr: ovs-ofctl: -:4: unknown keyword flow_group_id

Pushing a fix soon.

** Affects: neutron
     Importance: Low
     Assignee: Bence Romsics (bence-romsics)
         Status: In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2117477

Title:
  [unmaintained-only] unknown keyword flow_group_id

Status in neutron:
  In Progress

Bug description:
  I made a mistake in the backport of Ia61784174ee610b338f26660b2954330abc131a1.
  This bug tracks the fix for that mistake.
  Only unmaintained branches are affected.

  Earlier I backported this change:
  Ia61784174ee610b338f26660b2954330abc131a1 Add a default goto table=94 for openvswitch fw

  So today Ia61784174ee610b338f26660b2954330abc131a1 is merged on these branches:
  master
  stable/2025.1
  stable/2024.2
  stable/2024.1
  unmaintained/2023.1
  unmaintained/zed
  unmaintained/yoga
  unmaintained/xena
  unmaintained/wallaby
  unmaintained/victoria

  Ia61784174ee610b338f26660b2954330abc131a1 uses 'flow_group_id', therefore it depends on this change:
  If4984dece266a789d607725f8497f1aac3d73d23 Allow to process FW OF rules belonging to a port in a single operation

  In my earlier backports I did not notice this dependency.

  Today If4984dece266a789d607725f8497f1aac3d73d23 is merged only on these branches:
  master
  stable/2025.1
  stable/2024.2
  stable/2024.1
  unmaintained/2023.1
  unmaintained/zed

  Therefore we have some old branches, where Ia61784174ee610b338f26660b2954330abc131a1 is merged but its dependency If4984dece266a789d607725f8497f1aac3d73d23 is not:
  unmaintained/yoga
  unmaintained/xena
  unmaintained/wallaby
  unmaintained/victoria

  Just to double check, zed seems ok, but older branches are not:
  ack --ignore-dir=neutron/tests -l flow_group_id neutron
  unmaintained/zed
    neutron/agent/linux/openvswitch_firewall/firewall.py
    neutron/agent/common/ovs_lib.py
  unmaintained/yoga
    neutron/agent/linux/openvswitch_firewall/firewall.py
  unmaintained/xena
    neutron/agent/linux/openvswitch_firewall/firewall.py
  unmaintained/wallaby
    neutron/agent/linux/openvswitch_firewall/firewall.py
  unmaintained/victoria                                                                                                                                                                                                                          
    neutron/agent/linux/openvswitch_firewall/firewall.py

  On the problematic branches we do not handle flow_group_id, therefore
  it reaches ovs, that reports not knowing flow_group_id:

  2025-07-16T15:00:20.810204+02:00 compute2.cee.tld neutron-openvswitch-agent[113904]: neutron.agent.linux.utils - ERROR - Exit code: 1; Cmd: ['ovs-ofctl', 'add-flows', '-O', 'OpenFlow10', 'br-int', '--bundle', '-']; Stdin: hard_timeout=0,idle_timeout=0,priority=100,table=60,in_port=12,cookie=3266576298366935998,actions=set_field:12->reg5,set_field:9->reg6,resubmit(,73)
  hard_timeout=0,idle_timeout=0,priority=80,table=73,reg5=12,cookie=3266576298366935998,actions=resubmit(,94)
  hard_timeout=0,idle_timeout=0,priority=12,table=94,dl_dst=fa:16:3e:54:6a:83,reg6=9,cookie=3266576298366935998,actions=output:12
  hard_timeout=0,idle_timeout=0,priority=12,flow_group_id=12,table=94,dl_dst=fa:16:3e:54:6a:83,dl_vlan=9,cookie=3266576298366935998,actions=strip_vlan,output:12
  hard_timeout=0,idle_timeout=0,priority=10,table=94,dl_src=fa:16:3e:54:6a:83,dl_dst=00:00:00:00:00:00/01:00:00:00:00:00,reg6=9,cookie=3266576298366935998,actions=mod_vlan_vid:9,output:1; Stdout: ; Stderr: ovs-ofctl: -:4: unknown keyword flow_group_id

  Pushing a fix soon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2117477/+subscriptions
  Thread Previous • Date Previous • • Thread Next