yahoo-eng-team team mailing list archive

[OpenStack Infra <2118876@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/955987
Committed: https://opendev.org/openstack/neutron/commit/89b4b88846955d4bf40c15d06648a5ace76b3d22
Submitter: "Zuul (22348)"
Branch:    master

commit 89b4b88846955d4bf40c15d06648a5ace76b3d22
Author: yatinkarel <ykarel@xxxxxxxxxx>
Date:   Mon Jul 28 10:23:11 2025 +0530

    [OVN] Fix OVN agent register process
    
    OVN agent was wrongly getting recognized as OVN Metadata
    agent. This patch fixes it:
    * Adds a register method in the ``start`` method of the
      main process of the OVN agent. This register method adds
      the "neutron:ovn-neutron-agent-id" tag to the "Chassis_Private"
      register.
    * The metadata extension no longer registers the
      "neutron:ovn-neutron-agent-sb-cfg" key but the OVN agent.
    * Updates the ``ChassisOVNAgentWriteEvent`` to handle OVN agent
      tags along with OVN Metadata agent ones. NOTE: this class has
      changed its name.
    
    Closes-Bug: #2118876
    Change-Id: Ide12aa5ef8dca1ebcdfeb21bf5dac0a287dd0e44
    Signed-off-by: yatinkarel <ykarel@xxxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2118876

Title:
  OVN Neutron agent is being registered as OVN Metadata agent

Status in neutron:
  Fix Released

Bug description:
  Noticed during the fix of
  https://bugs.launchpad.net/neutron/+bug/2118398.

  The deployment have "enable_service q-ovn-agent"
  Service enabled and functional:-
  ● devstack@q-ovn-agent.service - Devstack devstack@q-ovn-agent.service
       Loaded: loaded (/etc/systemd/system/devstack@q-ovn-agent.service; enabled; preset: enabled)
       Active: active (running) since Thu 2025-07-24 14:39:01 UTC; 38min ago
     Main PID: 78453 (neutron-ovn-age)
        Tasks: 61 (limit: 38433)
       Memory: 562.9M (peak: 574.0M)
          CPU: 34.445s
       CGroup: /system.slice/system-devstack.slice/devstack@q-ovn-agent.service
               ├─ 78453 "neutron-ovn-agent: master process [/opt/stack/data/venv/bin/neutron-ovn-agent --config-file /etc/neutron/plugins/ml2/ovn_agent.ini]"
               ├─ 79029 "neutron-ovn-agent: ServiceWrapper worker(0)"
               ├─ 79303 /opt/stack/data/venv/bin/python3.12 /usr/local/bin/privsep-helper --config-file /etc/neutron/plugins/ml2/ovn_agent.ini --privsep_context neutron.privileged.namespace_cmd --privsep_sock_path /tmp/tmpeagnc7r5/privsep.sock
               ├─ 82595 /opt/stack/data/venv/bin/python3.12 /usr/local/bin/privsep-helper --config-file /etc/neutron/plugins/ml2/ovn_agent.ini --privsep_context neutron.privileged.default --privsep_sock_path /tmp/tmpcn7it337/privsep.sock
               ├─ 99728 /opt/stack/data/venv/bin/python3.12 /usr/local/bin/privsep-helper --config-file /etc/neutron/plugins/ml2/ovn_agent.ini --privsep_context neutron.privileged.link_cmd --privsep_sock_path /tmp/tmphc1bgjm2/privsep.sock
               ├─ 99811 sudo /opt/stack/data/venv/bin/neutron-rootwrap-daemon /etc/neutron/rootwrap.conf
               ├─ 99823 /opt/stack/data/venv/bin/python3.12 /opt/stack/data/venv/bin/neutron-rootwrap-daemon /etc/neutron/rootwrap.conf
               ├─100831 haproxy -f /opt/stack/data/neutron/ovn-metadata-proxy/7dcf1163-f756-451e-ad53-fbe686386ba3.conf
               ├─101129 haproxy -f /opt/stack/data/neutron/ovn-metadata-proxy/6b53c1cc-a2d0-41f5-8979-34adc9c6bfdf.conf
               ├─101730 haproxy -f /opt/stack/data/neutron/ovn-metadata-proxy/2e8134cd-6264-44db-8e21-bbf5f069eba2.conf
               └─104547 haproxy -f /opt/stack/data/neutron/ovn-metadata-proxy/076ac313-6a80-400d-aa9f-5c703fff9677.conf

  
  But it's not registered as neutron agent correctly:-
  {'binary': 'neutron-ovn-metadata-agent', 'host': 'np24c36814c2204', 'heartbeat_timestamp': '2025-07-24 15:01:42', 'availability_zone': '', 'topic': 'n/a', 'description': '', 'configurations': {'chassis_name': '408a5cab-18bb-48ee-815d-2f3e71341e3c', 'bridge-mappings': 'public:br-ex'}, 'agent_type': 'OVN Metadata agent', 'id': '7083b794-6efb-5bde-882b-4416eb593682', 'alive': True, 'admin_state_up': True}

  Should instead have been Agent Type:- "OVN Neutron agent" and binary:-
  "neutron-ovn-agent"

  While checking locally can see two things:-
  - Not setting OVN_AGENT_NEUTRON_ID_KEY anywhere
  - ChassisMetadataAgentWriteEvent only watching for ovn metadata fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2118876/+subscriptions