← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2119346] [NEW] TypeError in test_saml_signing unit test

 

Public bug reported:

Unit test
`keystone.tests.unit.test_v3_federation.SAMLGenerationTests.test_saml_signing`
fails with concatenation TypeError.

Environment info:
 - Python 3.13.5
 - Ubuntu Questing development build

Steps to reproduce:
 - Clone keystone repo
 - run `tox -e py3`

Error:
==============================
Failed 1 tests - output below:
==============================

keystone.tests.unit.test_v3_federation.SAMLGenerationTests.test_saml_signing
----------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 528, in _sign_assertion
    stdout = subprocess.check_output(
        command_list,  # nosec : The contents
    ...<11 lines>...
        stderr=subprocess.STDOUT,
    )

      File "/usr/lib/python3.13/subprocess.py", line 472, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
               **kwargs).stdout
               ^^^^^^^^^

      File "/usr/lib/python3.13/subprocess.py", line 577, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)

    subprocess.CalledProcessError: Command '['xmlsec1', '--sign', '--
privkey-pem',
'examples/pki/private/signing_key.pem,examples/pki/certs/signing_cert.pem',
'--id-attr:ID', 'Assertion', '/tmp/tmp7idiblwq/tmpxqdd0sbl']' returned
non-zero exit status 1.

During handling of the above exception, another exception occurred:

    Traceback (most recent call last):

      File "/home/ubuntu/keystone-test/keystone/keystone/tests/unit/test_v3_federation.py", line 4066, in test_saml_signing
    response = generator.samlize_token(
        self.ISSUER,
    ...<6 lines>...
        self.GROUPS,
    )

      File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 101, in samlize_token
    assertion = _sign_assertion(assertion)

      File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 549, in _sign_assertion
    'output': ' ' + e.output if hasattr(e, 'output') else '',
              ~~~~^~~~~~~~~~

    TypeError: can only concatenate str (not "bytes") to str

** Affects: keystone
     Importance: Undecided
         Status: New

** Description changed:

  Unit test
  `keystone.tests.unit.test_v3_federation.SAMLGenerationTests.test_saml_signing`
- fails with following error.
+ fails with concatenation TypeError.
  
  Environment info:
-  - Python 3.13.5
-  - Ubuntu Questing development build
+  - Python 3.13.5
+  - Ubuntu Questing development build
  
  Steps to reproduce:
-  - Clone keystone repo
-  - run `tox -e py3`
+  - Clone keystone repo
+  - run `tox -e py3`
  
  Error:
  ==============================
  Failed 1 tests - output below:
  ==============================
  
  keystone.tests.unit.test_v3_federation.SAMLGenerationTests.test_saml_signing
  ----------------------------------------------------------------------------
  
  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
-     Traceback (most recent call last):
+     Traceback (most recent call last):
  
-       File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 528, in _sign_assertion
-     stdout = subprocess.check_output(
-         command_list,  # nosec : The contents
-     ...<11 lines>...
-         stderr=subprocess.STDOUT,
-     )
+       File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 528, in _sign_assertion
+     stdout = subprocess.check_output(
+         command_list,  # nosec : The contents
+     ...<11 lines>...
+         stderr=subprocess.STDOUT,
+     )
  
-       File "/usr/lib/python3.13/subprocess.py", line 472, in check_output
-     return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
-            ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-                **kwargs).stdout
-                ^^^^^^^^^
+       File "/usr/lib/python3.13/subprocess.py", line 472, in check_output
+     return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
+            ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+                **kwargs).stdout
+                ^^^^^^^^^
  
-       File "/usr/lib/python3.13/subprocess.py", line 577, in run
-     raise CalledProcessError(retcode, process.args,
-                              output=stdout, stderr=stderr)
+       File "/usr/lib/python3.13/subprocess.py", line 577, in run
+     raise CalledProcessError(retcode, process.args,
+                              output=stdout, stderr=stderr)
  
-     subprocess.CalledProcessError: Command '['xmlsec1', '--sign', '--
+     subprocess.CalledProcessError: Command '['xmlsec1', '--sign', '--
  privkey-pem',
  'examples/pki/private/signing_key.pem,examples/pki/certs/signing_cert.pem',
  '--id-attr:ID', 'Assertion', '/tmp/tmp7idiblwq/tmpxqdd0sbl']' returned
  non-zero exit status 1.
  
-     
  During handling of the above exception, another exception occurred:
  
+     Traceback (most recent call last):
  
-     Traceback (most recent call last):
+       File "/home/ubuntu/keystone-test/keystone/keystone/tests/unit/test_v3_federation.py", line 4066, in test_saml_signing
+     response = generator.samlize_token(
+         self.ISSUER,
+     ...<6 lines>...
+         self.GROUPS,
+     )
  
-       File "/home/ubuntu/keystone-test/keystone/keystone/tests/unit/test_v3_federation.py", line 4066, in test_saml_signing
-     response = generator.samlize_token(
-         self.ISSUER,
-     ...<6 lines>...
-         self.GROUPS,
-     )
+       File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 101, in samlize_token
+     assertion = _sign_assertion(assertion)
  
-       File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 101, in samlize_token
-     assertion = _sign_assertion(assertion)
+       File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 549, in _sign_assertion
+     'output': ' ' + e.output if hasattr(e, 'output') else '',
+               ~~~~^~~~~~~~~~
  
-       File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 549, in _sign_assertion
-     'output': ' ' + e.output if hasattr(e, 'output') else '',
-               ~~~~^~~~~~~~~~
- 
-     TypeError: can only concatenate str (not "bytes") to str
+     TypeError: can only concatenate str (not "bytes") to str

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/2119346

Title:
  TypeError in test_saml_signing unit test

Status in OpenStack Identity (keystone):
  New

Bug description:
  Unit test
  `keystone.tests.unit.test_v3_federation.SAMLGenerationTests.test_saml_signing`
  fails with concatenation TypeError.

  Environment info:
   - Python 3.13.5
   - Ubuntu Questing development build

  Steps to reproduce:
   - Clone keystone repo
   - run `tox -e py3`

  Error:
  ==============================
  Failed 1 tests - output below:
  ==============================

  keystone.tests.unit.test_v3_federation.SAMLGenerationTests.test_saml_signing
  ----------------------------------------------------------------------------

  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):

        File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 528, in _sign_assertion
      stdout = subprocess.check_output(
          command_list,  # nosec : The contents
      ...<11 lines>...
          stderr=subprocess.STDOUT,
      )

        File "/usr/lib/python3.13/subprocess.py", line 472, in check_output
      return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
             ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                 **kwargs).stdout
                 ^^^^^^^^^

        File "/usr/lib/python3.13/subprocess.py", line 577, in run
      raise CalledProcessError(retcode, process.args,
                               output=stdout, stderr=stderr)

      subprocess.CalledProcessError: Command '['xmlsec1', '--sign', '--
  privkey-pem',
  'examples/pki/private/signing_key.pem,examples/pki/certs/signing_cert.pem',
  '--id-attr:ID', 'Assertion', '/tmp/tmp7idiblwq/tmpxqdd0sbl']' returned
  non-zero exit status 1.

  During handling of the above exception, another exception occurred:

      Traceback (most recent call last):

        File "/home/ubuntu/keystone-test/keystone/keystone/tests/unit/test_v3_federation.py", line 4066, in test_saml_signing
      response = generator.samlize_token(
          self.ISSUER,
      ...<6 lines>...
          self.GROUPS,
      )

        File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 101, in samlize_token
      assertion = _sign_assertion(assertion)

        File "/home/ubuntu/keystone-test/keystone/keystone/federation/idp.py", line 549, in _sign_assertion
      'output': ' ' + e.output if hasattr(e, 'output') else '',
                ~~~~^~~~~~~~~~

      TypeError: can only concatenate str (not "bytes") to str

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/2119346/+subscriptions