yahoo-eng-team team mailing list archive

[OpenStack Infra <1938045@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/glance/+/926560
Committed: https://opendev.org/openstack/glance/commit/4653c3e338bb626cc5b50ed25e33a8968379cd0b
Submitter: "Zuul (22348)"
Branch:    master

commit 4653c3e338bb626cc5b50ed25e33a8968379cd0b
Author: Tobias Urdin <tobias.urdin@xxxxxxxxxx>
Date:   Mon Aug 19 19:21:47 2024 +0200

    Remove LegacyEngineFacade
    
    This removes the usage of EngineFacade which is a
    alias for LegacyEngineFacade that is being removed
    in [1].
    
    This moves to using correct reader and writer
    sessions as exposed by oslo.db
    
    This removes the custom retry code for deadlock
    and instead uses the implementation in oslo.db
    
    [1] https://review.opendev.org/c/openstack/oslo.db/+/798135
    
    Closes-Bug: #1938045
    Change-Id: Ia8f4bce68324ebcef533ed213816e9ab9a745a72
    Signed-off-by: Takashi Kajinami <kajinamit@xxxxxxxxxxxxxxx>


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1938045

Title:
  OsloDBDeprecationWarning: EngineFacade is deprecated; please use
  oslo_db.sqlalchemy.enginefacade

Status in Glance:
  Fix Released

Bug description:
  The following deprecation warning in continuously observed in unit
  test jobs.

  /home/zuul/src/opendev.org/openstack/glance/.tox/py39/lib/python3.9/site-
  packages/oslo_db/sqlalchemy/enginefacade.py:1366:
  OsloDBDeprecationWarning: EngineFacade is deprecated; please use
  oslo_db.sqlalchemy.enginefacade

  Example can be found here.
  https://zuul.opendev.org/t/openstack/build/744e2be61f5f459b9b2bcf7f046cd31e

  Usage of EngineFacade is deprecated since oslo.db 1.12.0
  https://github.com/openstack/oslo.db/commit/fdbd928b1fdf0334e1740e565ab8206fff54eaa6

  However there is one usage left in glance code.
  https://github.com/openstack/glance/blob/fa558885503121813bd7d9bacb63754ad5b61676/glance/db/sqlalchemy/api.py#L88

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1938045/+subscriptions