yahoo-eng-team team mailing list archive

[Sebastian Lohff <2120429@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

When handling port events inside fwaas, inside logapis need_to_notify()
we might get a list of ports where some of the ports do not exist in the
database anymore (maybe they already have been deleted?). For these
ports we want to check if they actually exist before doing something
with them.

Without guarding against this we might end up with something like this
every now and then:

AttributeError: 'NoneType' object has no attribute 'get'
  File "neutron_lib/callbacks/manager.py", line 189, in _notify_loop
    callback.method(resource, event, trigger, payload=payload)
  File "neutron_fwaas/services/logapi/common/fwg_callback.py", line 43, in handle_event
    if self.need_to_notify(context, ports_delta):
  File "neutron_fwaas/services/logapi/common/fwg_callback.py", line 57, in need_to_notify
    device_owner = port.get('device_owner', ''

** Affects: neutron
     Importance: Undecided
     Assignee: Sebastian Lohff (sebageek)
         Status: In Progress

** Changed in: neutron
     Assignee: (unassigned) => Sebastian Lohff (sebageek)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2120429

Title:
  Neutron FWaaS logapi fails to notify for already deleted ports

Status in neutron:
  In Progress

Bug description:
  When handling port events inside fwaas, inside logapis
  need_to_notify() we might get a list of ports where some of the ports
  do not exist in the database anymore (maybe they already have been
  deleted?). For these ports we want to check if they actually exist
  before doing something with them.

  Without guarding against this we might end up with something like this
  every now and then:

  AttributeError: 'NoneType' object has no attribute 'get'
    File "neutron_lib/callbacks/manager.py", line 189, in _notify_loop
      callback.method(resource, event, trigger, payload=payload)
    File "neutron_fwaas/services/logapi/common/fwg_callback.py", line 43, in handle_event
      if self.need_to_notify(context, ports_delta):
    File "neutron_fwaas/services/logapi/common/fwg_callback.py", line 57, in need_to_notify
      device_owner = port.get('device_owner', ''

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2120429/+subscriptions