← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2121586] Re: Trunk create form is broken

 

Reviewed:  https://review.opendev.org/c/openstack/horizon/+/958739
Committed: https://opendev.org/openstack/horizon/commit/dc868dc5314fb42562670bc3cb16b08c92307721
Submitter: "Zuul (22348)"
Branch:    master

commit dc868dc5314fb42562670bc3cb16b08c92307721
Author: Pavlo Shchelokovskyy <shchelokovskyy@xxxxxxxxx>
Date:   Wed Aug 20 11:54:28 2025 +0000

    Fix port listing for trunks case
    
    the project_id might already be in the params of GET request
    (as with trunk create or edit forms).
    
    Also, fix tenant vs project filtering in getting trunks
    
    Closes-Bug: #2121586
    Change-Id: Iacc24398526d344d49da9830e2667a70fec4d879
    Signed-off-by: Pavlo Shchelokovskyy <shchelokovskyy@xxxxxxxxx>


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/2121586

Title:
  Trunk create form is broken

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Trunk create form is broken for some time now, we specifically cought
  it on Epoxy.

  "Error: Unable to retrieve the ports." error pops up when opening the
  trunk create form, and ports are not populated in the form,

  The form makes /api/neutron/ports/?project_id=<project_id> request to
  backend and receives 500

  
  2025-08-28 09:42:49.544417 27 ERROR /var/lib/openstack/lib/python3.12/site-packages/openstack_dashboard/api/rest/utils.py [-] error invoking apiclient
  2025-08-28 09:42:49.544457 Traceback (most recent call last):
  2025-08-28 09:42:49.544462   File "/var/lib/openstack/lib/python3.12/site-packages/openstack_dashboard/api/rest/utils.py", line 128, in _wrapped
  2025-08-28 09:42:49.544466     data = function(self, request, *args, **kw)
  2025-08-28 09:42:49.544470            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  2025-08-28 09:42:49.544473   File "/var/lib/openstack/lib/python3.12/site-packages/openstack_dashboard/api/rest/neutron.py", line 143, in get
  2025-08-28 09:42:49.544478     result = api.neutron.port_list_with_trunk_types(request,
  2025-08-28 09:42:49.544481              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  2025-08-28 09:42:49.544485 TypeError: openstack_dashboard.api.neutron.port_list_with_trunk_types() got multiple values for keyword argument 'project_id'
  2025-08-28 09:42:49.545200 27 ERROR /var/lib/openstack/lib/python3.12/site-packages/django/utils/log.py [-] Internal Server Error: /api/neutron/ports/
  192.168.102.128 - - [28/Aug/2025:09:42:49 +0000] "GET /api/neutron/ports/?project_id=7a40626da09441429ee5e14e8ff1010b HTTP/1.1" 500 116 52351 "https://horizon.it.just.works/project/trunks"; "Mozil
  la/5.0 (Macintosh; Intel Mac OS X 10.15; rv:142.0) Gecko/20100101 Firefox/142.0"

  I tracked it down to
  https://review.opendev.org/q/If94e91e5ae6568e06096380c2bf65d08d20a5958
  got merged (and backported to Epoxy).

  The request.GET.dict() in the case of the form already contains
  project_id from request URL params, so the project_id kwarg is being
  passed twice.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/2121586/+subscriptions



References