yahoo-eng-team team mailing list archive

[dalekseev <2125070@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Running `nova-status upgrade check` invokes the `get_instances_without_type` method in `nova/virt/libvirt/machine_type_utils.py`.
This method checks the `hw_machine_type` for all instances, including those managed by the ironic driver where machine types are not supported.

It would be helpful if the check skipped instances whose compute node
has `compute_nodes.hypervisor_type == 'ironic'` (or maybe there is a
better way to filter) so the upgrade check only flags applicable VMs.


Steps to reproduce
==================
Deploy a server via nova using ironic nova driver. Use an image without `hw_machine_type` set.
Run `nova-manage libvirt list_unset_machine_type`


Expected result
==================
Only libirt instances listed (maybe hyperv too, idk), nova-status upgrade check returns 0

Actual result
==================
The ironic server we created in command's output, nova-status upgrade check fails


P.S. the warning message is incorrect, there is no `nova-manage machine_type list_unset` (at least now).
I used `nova-manage libvirt list_unset_machine_type`

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2125070

Title:
  "nova-manage libvirt list_unset_machine_type"  includes ironic
  instances

Status in OpenStack Compute (nova):
  New

Bug description:
  Running `nova-status upgrade check` invokes the `get_instances_without_type` method in `nova/virt/libvirt/machine_type_utils.py`.
  This method checks the `hw_machine_type` for all instances, including those managed by the ironic driver where machine types are not supported.

  It would be helpful if the check skipped instances whose compute node
  has `compute_nodes.hypervisor_type == 'ironic'` (or maybe there is a
  better way to filter) so the upgrade check only flags applicable VMs.

  
  Steps to reproduce
  ==================
  Deploy a server via nova using ironic nova driver. Use an image without `hw_machine_type` set.
  Run `nova-manage libvirt list_unset_machine_type`

  
  Expected result
  ==================
  Only libirt instances listed (maybe hyperv too, idk), nova-status upgrade check returns 0

  Actual result
  ==================
  The ironic server we created in command's output, nova-status upgrade check fails



  P.S. the warning message is incorrect, there is no `nova-manage machine_type list_unset` (at least now).
  I used `nova-manage libvirt list_unset_machine_type`

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/2125070/+subscriptions