← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2129284] Re: unittest test_ovsdb_monitor overwrites ovs.Stream module variables

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/964493
Committed: https://opendev.org/openstack/neutron/commit/bcb21726b399d321bb0fc2bc1fe05af2d50f111c
Submitter: "Zuul (22348)"
Branch:    master

commit bcb21726b399d321bb0fc2bc1fe05af2d50f111c
Author: Jakub Libosvar <libosvar@xxxxxxxxxx>
Date:   Tue Oct 21 19:01:12 2025 +0000

    Patch Stream methods with mock
    
    The original code did not patch the methods but assigned mocks
    effectively leaving the mock objects existent even after the
    test has finished.
    
    Closes-Bug: #2129284
    
    Change-Id: I61da9b061ed4c0c78c2a84d889ed6f39928329cc
    Signed-off-by: Jakub Libosvar <libosvar@xxxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2129284

Title:
  unittest test_ovsdb_monitor overwrites ovs.Stream module variables

Status in neutron:
  Fix Released

Bug description:
  The test sets mock directly instead of patching. In case the Stream
  object is used in a different test it's still mocked.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2129284/+subscriptions



References