yellow team mailing list archive

Thread
Date

[Bug 742490] Re: HTML is constructed using string concatenation in the structural subscription JS.

To: yellow@xxxxxxxxxxxxxxxxxxx
From: Benji York <benji@xxxxxxxxxxxxx>
Date: Thu, 21 Apr 2011 20:38:57 -0000
Reply-to: Bug 742490 <742490@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

** Changed in: launchpad
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Launchpad
Yellow Squad, which is a bug assignee.
https://bugs.launchpad.net/bugs/742490

Title:
  HTML is constructed using string concatenation in the structural
  subscription JS.

Status in Launchpad itself:
  Fix Released

Bug description:
  Instead of constructing HTML using string operations we should do
  things like this:

  var link = Y.Node.create("<span>See <a /></span>");
  link.one("a")
      .set("href", url)
      .set("text", desc);

  The code in question is located in lib/lp/registry/javascript
  /structural-subscription.js