yellow team mailing list archive

[Francesco Banconi <frankban@xxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/charms/oneiric/buildbot-slave/buildbot-relationship-fixes into lp:~yellow/charms/oneiric/buildbot-slave/trunk.

Requested reviews:
  Launchpad Yellow Squad (yellow)

For more details, see:
https://code.launchpad.net/~frankban/charms/oneiric/buildbot-slave/buildbot-relationship-fixes/+merge/92003

- some import cleanups.
- fixed retrieval functions (mercurial and git).
-- 
https://code.launchpad.net/~frankban/charms/oneiric/buildbot-slave/buildbot-relationship-fixes/+merge/92003
Your team Launchpad Yellow Squad is requested to review the proposed merge of lp:~frankban/charms/oneiric/buildbot-slave/buildbot-relationship-fixes into lp:~yellow/charms/oneiric/buildbot-slave/trunk.

=== modified file 'hooks/config-changed'
--- hooks/config-changed	2012-02-07 13:56:40 +0000
+++ hooks/config-changed	2012-02-08 09:35:51 +0000
@@ -5,7 +5,6 @@
 
 from helpers import (
     apt_get_install,
-    command,
     DictDiffer,
     get_config,
     install_extra_repository,

=== modified file 'hooks/install'
--- hooks/install	2012-02-07 13:56:40 +0000
+++ hooks/install	2012-02-08 09:35:51 +0000
@@ -8,7 +8,6 @@
     command,
     get_config,
     log,
-    run,
     )
 import os
 import shlex
@@ -42,14 +41,14 @@
     return target
 
 
-def hg_fetch(source, target):
+def hg_fetch(source, path):
     apt_get_install('mercurial')
     target = tempfile.mktemp()
     command('hg', 'clone', source, target)
     return os.path.join(target, path)
 
 
-def git_fetch(source, target):
+def git_fetch(source, path):
     apt_get_install('git')
     target = tempfile.mktemp()
     command('git', 'clone', source, target)