← Back to team overview

yellow team mailing list archive

Re: [Merge] lp:~gmb/charms/oneiric/buildbot-master/tests-fixes into lp:~yellow/charms/oneiric/buildbot-master/trunk

 

Review: Approve code

Hi Francesco and Graham,

These changes look good.

I think if you use base64.b64encode() you don't get the extra '\n' and may not need to strip it.

s/proably/probably


-- 
https://code.launchpad.net/~gmb/charms/oneiric/buildbot-master/tests-fixes/+merge/92091
Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-master/trunk.


References