yellow team mailing list archive

Thread
Date

Re: [Merge] lp:~frankban/charms/oneiric/buildbot-master/helpers-fixes into lp:~yellow/charms/oneiric/buildbot-master/trunk

To: mp+92534@xxxxxxxxxxxxxxxxxx
From: Brad Crittenden <bac@xxxxxxxxxxxxx>
Date: Fri, 10 Feb 2012 18:25:26 -0000
In-reply-to: <20120210174645.24241.27246.launchpad@ackee.canonical.com>
Reply-to: mp+92534@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

Francesco the changes look nice.  Moving make_charm_config_file to a shared spot is a good call.

Also the fix to 'su' seems to be good.  I see we have no test for that context manager, though.  Should be easy to do.  Would you mind adding a couple, including one that shows the proper handling in the event of an exception?
-- 
https://code.launchpad.net/~frankban/charms/oneiric/buildbot-master/helpers-fixes/+merge/92534
Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-master/trunk.

References

[Merge] lp:~frankban/charms/oneiric/buildbot-master/helpers-fixes into lp:~yellow/charms/oneiric/buildbot-master/trunk
From: Francesco Banconi, 2012-02-10