yellow team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Review: Approve

Hi Graham,

Thanks for this improvement for testing robustness.

* In wait_for_machines, when ensuring all machines are running, instead of looping over all and 'and'-ing the 'all_machines_running', why not just set it to false when you see the first one that is not running and then break out of the loop?  It would be nominally faster (not really an issue) but more readable, I think.

An inner function to get the machine data might be nice too since you repeat that call twice.

Otherwise it looks great.
-- 
https://code.launchpad.net/~gmb/charms/oneiric/buildbot-master/master-smart-timeouts/+merge/92733
Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-master/trunk.