yellow team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

Review: Approve

Brad, this looks great!  Nicely done, and nice to have helpers that can do this for us with future charms.

As I mentioned on IRC, please clean up the log messages in handle_config_changes one way or another, so that we no longer have a colon and two messages when one would do.

Making a chdir context manager would be nice.  We have one or two hanging around.  You mentioned you had found one in setuplxc.

I asked whether tar xvf will have the expanded file or the existing file win: you said the expanded one, which is good.

You pointed out there are no tests.  If there's a sane way to write them then that would be great.

Thank you!

Gary
-- 
https://code.launchpad.net/~bac/charms/oneiric/buildbot-master/history-s3/+merge/94262
Your team Launchpad Yellow Squad is requested to review the proposed merge of lp:~bac/charms/oneiric/buildbot-master/history-s3 into lp:~yellow/charms/oneiric/buildbot-master/trunk.