yellow team mailing list archive

[Francesco Banconi <frankban@xxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/launchpad/setuplxc-language-pack into lp:launchpad with lp:~frankban/launchpad/setuplxc-add-apt-repository as a prerequisite.

Requested reviews:
  Launchpad Yellow Squad (yellow)

For more details, see:
https://code.launchpad.net/~frankban/launchpad/setuplxc-language-pack/+merge/94762

== Changes ==

The environment variable LANG=C is used during launchpad dependencies 
installation: this way we can avoid installing `language-pack-en`.
-- 
https://code.launchpad.net/~frankban/launchpad/setuplxc-language-pack/+merge/94762
Your team Launchpad Yellow Squad is requested to review the proposed merge of lp:~frankban/launchpad/setuplxc-language-pack into lp:launchpad.

=== modified file 'utilities/setuplxc.py'
--- utilities/setuplxc.py	2012-02-27 13:13:56 +0000
+++ utilities/setuplxc.py	2012-02-27 13:13:56 +0000
@@ -48,7 +48,7 @@
     )
 DEPENDENCIES_DIR = '~/dependencies'
 DHCP_FILE = '/etc/dhcp/dhclient.conf'
-HOST_PACKAGES = ['ssh', 'lxc', 'libvirt-bin', 'bzr', 'language-pack-en']
+HOST_PACKAGES = ['ssh', 'lxc', 'libvirt-bin', 'bzr']
 HOSTS_FILE = '/etc/hosts'
 LP_APACHE_MODULES = 'proxy proxy_http rewrite ssl deflate headers'
 LP_APACHE_ROOTS = (
@@ -819,11 +819,7 @@
     root_sshcall("echo 'mountall hold' | dpkg --set-selections")
     # Upgrading packages.
     root_sshcall(
-        'apt-get update && '
-        'DEBIAN_FRONTEND=noninteractive '
-        'apt-get -y install language-pack-en')
-    root_sshcall(
-        'DEBIAN_FRONTEND=noninteractive apt-get -y '
+        'apt-get update && DEBIAN_FRONTEND=noninteractive LANG=C apt-get -y '
         'install {}'.format(LP_DEB_DEPENDENCIES))
     # We install lxc in the guest so that lxc-execute will work on the
     # container.  We use --no-install-recommends at the recommendation