← Back to team overview

yellow team mailing list archive

[Merge] lp:~benji/charms/oneiric/buildbot-slave/integration into lp:~yellow/charms/oneiric/buildbot-slave/trunk

 

Benji York has proposed merging lp:~benji/charms/oneiric/buildbot-slave/integration into lp:~yellow/charms/oneiric/buildbot-slave/trunk.

Requested reviews:
  Launchpad Yellow Squad (yellow)

For more details, see:
https://code.launchpad.net/~benji/charms/oneiric/buildbot-slave/integration/+merge/95381

Add the buildbot user to a group as a work-around to an LXC bug in lxc-start-ephemeral.
-- 
https://code.launchpad.net/~benji/charms/oneiric/buildbot-slave/integration/+merge/95381
Your team Launchpad Yellow Squad is requested to review the proposed merge of lp:~benji/charms/oneiric/buildbot-slave/integration into lp:~yellow/charms/oneiric/buildbot-slave/trunk.
=== modified file 'hooks/install'
--- hooks/install	2012-02-29 22:45:07 +0000
+++ hooks/install	2012-03-01 15:18:19 +0000
@@ -170,6 +170,9 @@
         # need (e.g. those that create lxc containers).  We choose sh as
         # a standard and basic "system" shell.
         run('usermod', '-s', '/bin/sh', 'buildbot')
+        # Some versions of LXC require the user to have a group.
+        run('addgroup', 'buildbot')
+        run('usermod', '--gid', 'buildbot', 'buildbot')
         sys.exit(handle_script(retrieve, url, path, args))
 
 


Follow ups