yellow team mailing list archive

[Francesco Banconi <frankban@xxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/launchpad/setuplxc-fstab-tweak into lp:launchpad.

Requested reviews:
  Launchpad Yellow Squad (yellow)

For more details, see:
https://code.launchpad.net/~frankban/launchpad/setuplxc-fstab-tweak/+merge/102483

= Summary =

We need to add a line to the container's fstab in order to work around 
bug 974584, still affecting lucid lxc.


== Implementation details ==

setuplxc adds the line to fstab right after the container is created.


== Demo and Q/A ==

We should no longer see semaphore errors in our parallel test runs.


== lint ==

Checking for conflicts and issues in changed files.

Linting changed files:
  utilities/setuplxc.py

-- 
https://code.launchpad.net/~frankban/launchpad/setuplxc-fstab-tweak/+merge/102483
Your team Launchpad Yellow Squad is requested to review the proposed merge of lp:~frankban/launchpad/setuplxc-fstab-tweak into lp:launchpad.

=== modified file 'utilities/setuplxc.py'
--- utilities/setuplxc.py	2012-04-13 21:11:45 +0000
+++ utilities/setuplxc.py	2012-04-18 10:19:22 +0000
@@ -1029,6 +1029,13 @@
         ])
     if exit_code:
         raise SetupLXCError('Unable to create the LXC container.')
+    # XXX 2012-04-18 frankban bug=974584:
+    #     Add a line to the container's fstab to be able to create semaphores
+    #     in lxc. This workaround needs to be removed once the lxc bug is
+    #     resolved for lucid containers too.
+    file_append(
+        '/var/lib/lxc/{}/fstab'.format(lxcname),
+        'none dev/shm tmpfs defaults 0 0\n')
     subprocess.call(['lxc-start', '-n', lxcname, '-d'])
     # Set up root ssh key.
     user_authorized_keys = os.path.expanduser(