yellow team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

The proposal to merge lp:~yellow/testrepository/bug988481 into lp:testrepository has been updated.

Description changed to:

This branch depends on lp:~yellow/subunit/real-time and lp:~yellow/subunit/test-count.  The following MP text is slightly modified from the MP for the first branch.

testrepository had a class (also called TestResultFilter) that tried to send all time calls through. To implement, it subclassed subunit's TestResultFilter and then reached into the _buffered_calls while in the stopTest method to try and find the time calls. Because of use of the decorator pattern, this was fragile.

The associated change in subunit gives that class the behavior that testrepository wants.

This change in subunit, plus the change in lp:~yellow/subunit/test-count, means that testrepository can use subunit's TestResultFilter directly, thereby getting rid of the fragility associated with the combination of subclassing, decorating, and accessing a protected attribute.

This is work done by Benji York and Brad Crittenden; I'm just helping out with the MP.

For more details, see:
https://code.launchpad.net/~yellow/testrepository/bug988481/+merge/103704
-- 
https://code.launchpad.net/~yellow/testrepository/bug988481/+merge/103704
Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/testrepository/bug988481.