yellow team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/launchpad/bug-993510 into lp:launchpad.

Requested reviews:
  Launchpad Yellow Squad (yellow)

For more details, see:
https://code.launchpad.net/~frankban/launchpad/bug-993510/+merge/107630

= Summary =

Log handlers are removed before each test because tests should not depend on global logging config.

== Changes ==

Iterate over a copy of the handler list, so that the original list is not affected by the .remove calls and all handlers are correctly removed.

NO QA

== Lint == 

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/testing/__init__.py

== Tests ==

$ bin/test -vvc --load-list ../s6 
Running tests at level 1
Running lp.testing.layers.LaunchpadZopelessLayer tests:
  Set up lp.testing.layers.BaseLayer in 0.052 seconds.
  Set up lp.testing.layers.ZopelessLayer in 3.405 seconds.
  Set up lp.testing.layers.DatabaseLayer in 1.217 seconds.
  Set up lp.testing.layers.LibrarianLayer in 5.545 seconds.
  Set up lp.testing.layers.MemcachedLayer in 0.113 seconds.
  Set up lp.testing.layers.RabbitMQLayer in 1.501 seconds.
  Set up lp.testing.layers.LaunchpadLayer in 0.000 seconds.
  Set up lp.testing.layers.LaunchpadScriptLayer in 0.003 seconds.
  Set up lp.testing.layers.LaunchpadZopelessLayer in 0.000 seconds.
  Running:
 lp.archivepublisher.tests.test_publish_ftpmaster.TestPublishFTPMasterScript.test_script_is_happy_with_no_publications
 lp.services.job.tests.test_runner.TestJobRunner.test_runJobHandleErrors_oops_generated_user_notify_failsNo handlers could be found for logger "root"

  Ran 2 tests with 0 failures and 0 errors in 2.726 seconds.
Tearing down left over layers:
  Tear down lp.testing.layers.LaunchpadZopelessLayer in 0.000 seconds.
  Tear down lp.testing.layers.LaunchpadScriptLayer in 0.001 seconds.
  Tear down lp.testing.layers.ZopelessLayer ... not supported
  Tear down lp.testing.layers.LaunchpadLayer in 0.000 seconds.
  Tear down lp.testing.layers.LibrarianLayer in 0.137 seconds.
  Tear down lp.testing.layers.MemcachedLayer in 0.001 seconds.
  Tear down lp.testing.layers.RabbitMQLayer ... not supported
  Tear down lp.testing.layers.DatabaseLayer in 0.162 seconds.
  Tear down lp.testing.layers.BaseLayer in 0.001 seconds.

-- 
https://code.launchpad.net/~frankban/launchpad/bug-993510/+merge/107630
Your team Launchpad Yellow Squad is requested to review the proposed merge of lp:~frankban/launchpad/bug-993510 into lp:launchpad.

=== modified file 'lib/lp/testing/__init__.py'
--- lib/lp/testing/__init__.py	2012-05-03 14:06:03 +0000
+++ lib/lp/testing/__init__.py	2012-05-28 14:17:19 +0000
@@ -650,7 +650,7 @@
         # Remove all log handlers, tests should not depend on global logging
         # config but should make their own config instead.
         logger = logging.getLogger()
-        for handler in logger.handlers:
+        for handler in list(logger.handlers):
             logger.removeHandler(handler)
 
     def assertStatementCount(self, expected_count, function, *args, **kwargs):