yellow team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Francesco Banconi has proposed merging lp:~frankban/lpsetup/bug-1012166-unsupported-lang into lp:lpsetup.

Requested reviews:
  Yellow Squad (yellow)
Related bugs:
  Bug #1012166 in lpsetup: "bzr related tests fail in LXC with unexpected LANG environment"
  https://bugs.launchpad.net/lpsetup/+bug/1012166

For more details, see:
https://code.launchpad.net/~frankban/lpsetup/bug-1012166-unsupported-lang/+merge/109872

== Changes ==

Added 'env -u LANG' to avoid bzr errors. See the bug description.


-- 
https://code.launchpad.net/~frankban/lpsetup/bug-1012166-unsupported-lang/+merge/109872
Your team Yellow Squad is requested to review the proposed merge of lp:~frankban/lpsetup/bug-1012166-unsupported-lang into lp:lpsetup.

=== modified file 'lpsetup/templates/lp-setup-lxc-test'
--- lpsetup/templates/lp-setup-lxc-test	2012-04-10 16:36:15 +0000
+++ lpsetup/templates/lp-setup-lxc-test	2012-06-12 15:27:34 +0000
@@ -13,8 +13,11 @@
 #     touch a; touch b; ssh localhost -- ls "a b"
 # succeeds, when it should say that the file "a b" does not exist.
 
+# We remove the LANG env var in the ssh call to avoid bzr errors occurring
+# when the host sends a LANG not supported by the container.
+
 set -uex
 lxc-start-ephemeral -u {user} -S '{ssh_key_path}' -o {lxc_name} -- \
-    "xvfb-run --error-file=/var/tmp/xvfb-errors.log \
+    "env -u LANG xvfb-run --error-file=/var/tmp/xvfb-errors.log \
     --server-args='-screen 0 1024x768x24' \
     -a $PWD/bin/test --shuffle --subunit $@"