yellow team mailing list archive

Thread
Date

Re: Preserve zoom settings in the environment view. (issue 6720048)

To: mp+130087@xxxxxxxxxxxxxxxxxx
From: Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>
Date: Wed, 17 Oct 2012 14:28:22 -0000
In-reply-to: <20121017110225.7805.4629.launchpad@ackee.canonical.com>
Reply-to: mp+130087@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Thanks for the review Matthew.


https://codereview.appspot.com/6720048/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6720048/diff/1/app/views/environment.js#newcode1163
app/views/environment.js:1163: // Store the current value of translate
by copying the event array
On 2012/10/17 14:11:34, matthew.scott wrote:
> Minor: I know the above line was there before, but maybe it deserves a
comment
> as well, possibly just merged with this comment.

Done.

https://codereview.appspot.com/6720048/

-- 
https://code.launchpad.net/~frankban/juju-gui/preserve-zoom/+merge/130087
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/preserve-zoom into lp:juju-gui.

References

[Merge] lp:~frankban/juju-gui/preserve-zoom into lp:juju-gui
From: Francesco Banconi, 2012-10-17