← Back to team overview

yellow team mailing list archive

Re: Service health graphs consistently rendered (issue 6718048)

 

LGTM


https://codereview.appspot.com/6718048/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6718048/diff/1/app/views/environment.js#newcode784
app/views/environment.js:784: });
This looks fine to me, can we however be sure those are the only three
states bubbling to this layer? I know that is supposed to be the case,
but should these ever come out of sync having a fallback value here
might make sense.

Probably fine for now though

https://codereview.appspot.com/6718048/

-- 
https://code.launchpad.net/~makyo/juju-gui/consistent-health-graph/+merge/130005
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/consistent-health-graph into lp:juju-gui.


References