yellow team mailing list archive

[Thiago Veronezi <thiago@xxxxxxxxxxxx>]

https://codereview.appspot.com/6724059/diff/5002/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/6724059/diff/5002/app/views/service.js#newcode655
app/views/service.js:655: charm: renderableCharm}
On 2012/10/19 19:36:04, hazmat wrote:
> the charm is referenced by id only in the templates, so all of these
only need
>   charm_id: service.get('charm')

> ie. the renderable_charm call here is extraneous.

Done.

https://codereview.appspot.com/6724059/diff/5002/app/views/service.js#newcode822
app/views/service.js:822: var renderableCharm =
this.renderable_charm(service.get('charm'),
On 2012/10/19 19:36:04, hazmat wrote:
> renderableCharm/renderedCharm

> these lines could be removed afaics, and made internal to the
getServiceTabs and
> since its only needs app.getModelURL(this.get('charm')) the call to
> renderable_charm can be omitted.

Done.

https://codereview.appspot.com/6724059/

-- 
https://code.launchpad.net/~tveronezi/juju-gui/service-header/+merge/130243
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~tveronezi/juju-gui/service-header into lp:juju-gui.