← Back to team overview

yellow team mailing list archive

Re: Make target for appcache manifest (issue 6776052)

 

https://codereview.appspot.com/6776052/diff/5/Makefile
File Makefile (right):

https://codereview.appspot.com/6776052/diff/5/Makefile#newcode50
Makefile:50: @sed -re 's/^\# TIMESTAMP .+$$/\# TIMESTAMP $(DATE)/' -i
$(APPCACHE)
Did a bit of research and found http://appcachefacts.info/ which
suggests that touch may not be enough.  I suspect that this may be
server dependent, but as we're not sure of which server the gui will be
deployed on, I think this might be safer.
On 2012/10/28 12:25:14, gary.poster wrote:
> As I said on IRC, I'm not sure why this is preferable to simply
touching the
> file.  Touching seems simpler, so attractive to me.  Maybe it is
insufficient or
> maybe you prefer the written timestamp.  If you've considered touch,
and you
> prefer to go with what you have here, then that's cool.

https://codereview.appspot.com/6776052/

-- 
https://code.launchpad.net/~makyo/juju-gui/make-appcache/+merge/131586
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/make-appcache into lp:juju-gui.


References