yellow team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

Cool, thank you Thiago. We had a few other related comments on our face
to face discussion.  In particular, sprite.css and sprite.png ought to
also depend on grunt and spritesheet.

Gary


https://codereview.appspot.com/6811050/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode11
Makefile:11: node_modules/grunt node_modules/node-spritesheet
SPRITE_IMAGES=$(shell bzr ls -k file app/assets/images)

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode52
Makefile:52:
app/assets/sprite/sprite.css app/assets/sprite/sprite.png:
$(SPRITE_IMAGES)
         rm -Rf bin/sprite/
         rm -Rf app/assets/sprite/
         @node_modules/grunt/bin/grunt spritegen
         mv bin/sprite app/assets/sprite/

spritegen: app/assets/sprite/sprite.css app/assets/sprite/sprite.png

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode87
Makefile:87: appcache appcache-touch appcache-force
... \
spritegen yuidoc-lint

https://codereview.appspot.com/6811050/diff/1/app/index.html
File app/index.html (right):

https://codereview.appspot.com/6811050/diff/1/app/index.html#newcode30
app/index.html:30: <img alt="Juju GUI"
As we discussed, we have precedence in the codebase with <i> rather than
<img>, because of bootstrap.css

https://codereview.appspot.com/6811050/

-- 
https://code.launchpad.net/~tveronezi/juju-gui/spritegen/+merge/132077
Your team Juju GUI Hackers is subscribed to branch lp:juju-gui.