← Back to team overview

yellow team mailing list archive

Re: Change charm search to use HTML5 placeholder (issue 6816046)

 

Nice change Gary both in effect and implementation.  Thanks.  I hope it
can land very soon.


https://codereview.appspot.com/6816046/diff/1/app/index.html
File app/index.html (right):

https://codereview.appspot.com/6816046/diff/1/app/index.html#newcode57
app/index.html:57: required="required" placeholder="Search for a charm"
/>
Nice improvement!  I was afraid we were going to have to wait for DOM
ready events to re-enable the field in order to solve this problem.
Glad you figured out the True solution.

https://codereview.appspot.com/6816046/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6816046/diff/1/lib/views/stylesheet.less#newcode103
lib/views/stylesheet.less:103: box-shadow: inset 0 1px 1px rgba(0, 0, 0,
0.075), 0 0 8px rgba(82, 168, 236, 0.6);
This line should be wrapped.

https://codereview.appspot.com/6816046/

-- 
https://code.launchpad.net/~gary/juju-gui/placeholder/+merge/131788
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~gary/juju-gui/placeholder into lp:juju-gui.


References