← Back to team overview

yellow team mailing list archive

Re: CSS styling for buttons (issue 6811062)

 

Thanks, Brad.

Seems good to me.
I have only two silly comments.

[]s,
Thiago.


https://codereview.appspot.com/6811062/diff/5001/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6811062/diff/5001/lib/views/stylesheet.less#newcode744
lib/views/stylesheet.less:744: //@shadow-color: blue;
This line is commented out. Probably you can remove it.

https://codereview.appspot.com/6811062/diff/5001/lib/views/stylesheet.less#newcode746
lib/views/stylesheet.less:746: @gradient-start: @top-color;
You could use the top-color and botton-color instead of the new
pointers, right? If you want less code changes, you can change the
parameter names to gradient-start and gradient-end.

https://codereview.appspot.com/6811062/

-- 
https://code.launchpad.net/~bac/juju-gui/css-buttons/+merge/132365
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~bac/juju-gui/css-buttons into lp:juju-gui.


References