yellow team mailing list archive

[Thiago Veronezi <thiago@xxxxxxxxxxxx>]

The proposal to merge lp:~tveronezi/juju-gui/generic-show-view-event into lp:juju-gui has been updated.

Description changed to:

Generic show view event

Instead of wrapping the 'navigate' method call with multiple 'show' events, we want call the 'navigate' method from a single event.

So, instead of...

this.on('*:showService', this.navigate_to_service);
this.on('*:showUnit', this.navigate_to_unit);
this.on('*:showCharm', this.navigate_to_charm);
this.on('*:showEnvironment', this.navigate_to_environment);

... we will have...

this.on('*:navigateTo', function(e) {
 console.log('navigateTo', e);
 this.navigate(e.url);
}, this);

https://codereview.appspot.com/6819104/


For more details, see:
https://code.launchpad.net/~tveronezi/juju-gui/generic-show-view-event/+merge/133247
-- 
https://code.launchpad.net/~tveronezi/juju-gui/generic-show-view-event/+merge/133247
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~tveronezi/juju-gui/generic-show-view-event into lp:juju-gui.