| Thread Previous • Date Previous • Date Next • Thread Next |
Hi Brad. This really looks much better, thank you.
Matt is the one who will be pickier than I, but here's a start:
- The visual design doesn't seem to bold the series names or the charm
names, but they are bold in the app right now.
- It looks to me like there is too much space between the package name
and the summary, in comparison to the visual design.
- The visual design looks like it might be alternating darker and
lighter gray background colors for each package, and then using the
lighter gray color for mouseover. I'm not sure that's right, but
something is going on, and it probably warrants checking with Matt.
- If you search for something that is available in multiple series (I
used "buildbot" :-) ) then the top line of the second series (Oneiric,
in this case) looks too thick. AFAICT, the last .charm-entry should not
have a bottom-border. That fixes it for me. "&:last-child {
bottom-border: 0; }" maybe?
That's it. Fix those and I'm automatically +1. Thanks!
Gary
https://codereview.appspot.com/6817101/
--
https://code.launchpad.net/~bac/juju-gui/charm-search-style/+merge/133325
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~bac/juju-gui/charm-search-style into lp:juju-gui.
| Thread Previous • Date Previous • Date Next • Thread Next |
