← Back to team overview

yellow team mailing list archive

Re: Generic show view event (issue 6819104)

 

*** Submitted:

Generic show view event

Instead of wrapping the 'navigate' method call with multiple 'show'
events, we want call the 'navigate' method from a single event.

So, instead of...

this.on('*:showService', this.navigate_to_service);
this.on('*:showUnit', this.navigate_to_unit);
this.on('*:showCharm', this.navigate_to_charm);
this.on('*:showEnvironment', this.navigate_to_environment);

... we will have...

this.on('*:navigateTo', function(e) {
  console.log('navigateTo', e);
  this.navigate(e.url);
}, this);

R=benji, bac
CC=
https://codereview.appspot.com/6819104


https://codereview.appspot.com/6819104/

-- 
https://code.launchpad.net/~tveronezi/juju-gui/generic-show-view-event/+merge/133247
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~tveronezi/juju-gui/generic-show-view-event into lp:juju-gui.


References