← Back to team overview

yellow team mailing list archive

Re: Charm config panel visual design fixes. (issue 6827066)

 

Great changes, Francesco!  No suggestions or requests.  Thanks!

Gary


https://codereview.appspot.com/6827066/diff/2002/app/views/charm-panel.js
File app/views/charm-panel.js (right):

https://codereview.appspot.com/6827066/diff/2002/app/views/charm-panel.js#newcode600
app/views/charm-panel.js:600: * @return {undefined} Dispatches only.
Awesome.  Thank you for this and the other docs

https://codereview.appspot.com/6827066/diff/2002/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6827066/diff/2002/lib/views/stylesheet.less#newcode1
lib/views/stylesheet.less:1: /* Processed with LESS from
lib/views/stylesheet.less */
Great changes here, Francesco.

https://codereview.appspot.com/6827066/diff/2002/undocumented
File undocumented (left):

https://codereview.appspot.com/6827066/diff/2002/undocumented#oldcode81
undocumented:81: app/views/charm-panel.js onFileRemove
Thank you!

https://codereview.appspot.com/6827066/

-- 
https://code.launchpad.net/~frankban/juju-gui/bug-1075679-charm-config-panel/+merge/133657
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/bug-1075679-charm-config-panel into lp:juju-gui.


References