yellow team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

On 2012/11/12 18:28:34, bac wrote:
> Thanks Francesco.  I'm concerned about being able to repeatedly open
and close
> the Charms panel using the top-level twisty.

> Otherwise, looks good.

Thanks for the review Brad.



https://codereview.appspot.com/6819131/diff/1/app/templates/charm-description.handlebars
> File app/templates/charm-description.handlebars (right):


https://codereview.appspot.com/6819131/diff/1/app/templates/charm-description.handlebars#newcode15
> app/templates/charm-description.handlebars:15: <h4 class="first"><i
> class="sprite chevron_up"></i> Description</h4>
> I find chevron-up vs -down counter intuitive but it matches the visual
design.

Agreed.


> Also I note with your branch that after loading I can click on the
Charms icon
> at the top and have it work exactly once.  If I close it I cannot
reopen.
> Please check that behavior in your branch before submitting.

Works for me locally, after cleaning the browser cache.

> Additionally it doesn't look like the chevron twists for the top
Charms label.

They are correctly replaced here. :-/ I think some kind of cache is
hitting us.



https://codereview.appspot.com/6819131/

-- 
https://code.launchpad.net/~frankban/juju-gui/bug-1075672-icons/+merge/133944
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/bug-1075672-icons into lp:juju-gui.