yellow team mailing list archive

[Benji York <benji.york@xxxxxxxxxxxxx>]

Benji York has proposed merging lp:~benji/juju-gui/bug-1075674 into lp:juju-gui.

Requested reviews:
  Juju GUI Hackers (juju-gui)

For more details, see:
https://code.launchpad.net/~benji/juju-gui/bug-1075674/+merge/134117

Remove the fade in/out of the charm panel.



https://codereview.appspot.com/6854043/

-- 
https://code.launchpad.net/~benji/juju-gui/bug-1075674/+merge/134117
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~benji/juju-gui/bug-1075674 into lp:juju-gui.

=== modified file 'app/views/charm-panel.js'
--- app/views/charm-panel.js	2012-11-13 13:55:32 +0000
+++ app/views/charm-panel.js	2012-11-13 14:58:20 +0000
@@ -804,7 +804,6 @@
     var charmStore = config.charm_store,
         charms = new models.CharmList(),
         app = config.app,
-        testing = !!config.testing,
         container = Y.Node.create('<div />').setAttribute(
             'id', 'juju-search-charm-panel'),
         charmsSearchPanelNode = Y.Node.create(),
@@ -898,7 +897,7 @@
             headerSpan.addClass('active-border');
           }
         }
-        container.hide(!testing, {duration: 0.25});
+        container.hide();
         if (Y.Lang.isValue(trigger)) {
           trigger.one('i#charm-search-chevron').replaceClass(
               'chevron_up', 'chevron_down');
@@ -937,7 +936,7 @@
           }
         }
         container.setStyles({opacity: 0, display: 'block'});
-        container.show(!testing, {duration: 0.25});
+        container.show();
         isPanelVisible = true;
         updatePanelPosition();
         if (Y.Lang.isValue(trigger)) {