yellow team mailing list archive
-
yellow team
-
Mailing list archive
-
Message #01618
Re: Remove ability to remove subordinate relations. (issue 6846060)
Looks good, except for the few things noted. Thanks.
https://codereview.appspot.com/6846060/diff/1/app/views/environment.js
File app/views/environment.js (right):
https://codereview.appspot.com/6846060/diff/1/app/views/environment.js#newcode456
app/views/environment.js:456: .removeClass('yui5-button');
You discovered this typo when we chatted.
https://codereview.appspot.com/6846060/diff/1/test/test_environment_view.js
File test/test_environment_view.js (right):
https://codereview.appspot.com/6846060/diff/1/test/test_environment_view.js#newcode410
test/test_environment_view.js:410:
panel.one('button').simulate('click');
How do we know this happened?
https://codereview.appspot.com/6846060/
--
https://code.launchpad.net/~makyo/juju-gui/no-remove-sub-rels/+merge/134495
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/no-remove-sub-rels into lp:juju-gui.
References