yellow team mailing list archive

[Thiago Veronezi <thiago@xxxxxxxxxxxx>]

Thanks Matt. It looks good.

I have just one comment, but it can be not related to this card.

[]s,
Thiago.


https://codereview.appspot.com/6846060/diff/4001/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6846060/diff/4001/app/views/environment.js#newcode1235
app/views/environment.js:1235: view.get('rmrelation_dialog').destroy();
During my tests I noticed that we dont do the same thing for the regular
relations. In other words, we keep adding a new div to the
"rmrelation-modal-panel" div every time we try to remove a regular
relation. Probably you could fix that here.

https://codereview.appspot.com/6846060/

-- 
https://code.launchpad.net/~makyo/juju-gui/no-remove-sub-rels/+merge/134495
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/no-remove-sub-rels into lp:juju-gui.