← Back to team overview

yellow team mailing list archive

[Merge] lp:~bac/juju-gui/charm-spill into lp:juju-gui

 

The proposal to merge lp:~bac/juju-gui/charm-spill into lp:juju-gui has been updated.

Description changed to:

Fix overflow on charm name.

The sections in the charm search results pane are fixed at 70px high.
Due to the way we construct the name, and the fact the charm authors
can set the name to be anything they want, some names exceed the
allotted one-line and wreak havoc on the layout.

Obvious lesson learned: any element with a fixed height and
user-supplied data must account for overflow.

The deploy button placement was also fixed.

Matt C. has seen screenshots of the truncation and offered tweaks on
the vertical spacing which are incorporated here.

https://codereview.appspot.com/6843082/


For more details, see:
https://code.launchpad.net/~bac/juju-gui/charm-spill/+merge/134961
-- 
https://code.launchpad.net/~bac/juju-gui/charm-spill/+merge/134961
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~bac/juju-gui/charm-spill into lp:juju-gui.


References