← Back to team overview

yellow team mailing list archive

[Merge] lp:~bac/juju-gui/picker-tweak into lp:juju-gui

 

Brad Crittenden has proposed merging lp:~bac/juju-gui/picker-tweak into lp:juju-gui.

Requested reviews:
  Juju GUI Hackers (juju-gui)

For more details, see:
https://code.launchpad.net/~bac/juju-gui/picker-tweak/+merge/138203

Tweaks to the charm store picker CSS.

Fixed spacing on text and placement of the activetick.
Also changed expanded widget to drop straight down instead of shifting
to the right.

Changes suggested by Matt C.  Self-reviewed.
-- 
https://code.launchpad.net/~bac/juju-gui/picker-tweak/+merge/138203
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~bac/juju-gui/picker-tweak into lp:juju-gui.
=== modified file 'lib/views/stylesheet.less'
--- lib/views/stylesheet.less	2012-12-03 20:36:19 +0000
+++ lib/views/stylesheet.less	2012-12-05 15:12:40 +0000
@@ -670,7 +670,7 @@
             position: absolute;
             bottom: @listbottom;
             top: @listtop;
-            left: 4px;
+            left: 0px;
             height: 100%;
             background: url(/juju-ui/assets/images/view_1px.png) repeat-x;
             list-style-type: none;
@@ -682,12 +682,12 @@
 
             ul {
                 list-style-type: none;
-                padding: 0;
                 padding-top: 5px;
+		padding-bottom: 5px;
                 margin: 0;
 
                 li {
-                    padding: 1px;
+                    padding-left: 7px;
                     &.activetick {
                         /* XXX bac: The positioning is off but I have
                          * been unable to get it right.  Using
@@ -695,7 +695,8 @@
                          */
                         background:
                             url(/juju-ui/assets/images/selected_tick.png)
-                            no-repeat bottom right;
+                            no-repeat;
+			background-position: 240px 3px;
                     }
                 }
             }
@@ -748,7 +749,6 @@
         top: @top;
         .create-picker(270px, @top, @top, initial);
         .picker-expanded .picker-list {
-            border: 1px solid #a3a1a1;
             .create-border-radius(4px);
             -moz-background-clip: padding;
             -webkit-background-clip: padding-box;


Follow ups