← Back to team overview

yellow team mailing list archive

Re: Add the ability to make releases to the Makefile (issue 6909046)

 

Lots of docs, I like it. Where are the Makefile tests? ;-) Ok, just
joking. Well, 50% joking. Well, 10% joking. Well...


https://codereview.appspot.com/6909046/diff/1/CHANGES.yaml
File CHANGES.yaml (right):

https://codereview.appspot.com/6909046/diff/1/CHANGES.yaml#newcode1
CHANGES.yaml:1: # This file keeps track of the changes to the file.  We
use it both to
"the changes to the file"? What file?

https://codereview.appspot.com/6909046/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/6909046/diff/1/Makefile#newcode27
Makefile:27: ### Relase-specific variables - see docs/process.rst for an
overview. ###
"Relase" -> "Release"

https://codereview.appspot.com/6909046/diff/1/Makefile#newcode83
Makefile:83: ### End of relase-specific variables ###
"relase" -> "release"

https://codereview.appspot.com/6909046/diff/1/README
File README (right):

https://codereview.appspot.com/6909046/diff/1/README#newcode158
README:158: work. Go to the #launchpad-ops channel on the canonical IRC
server and ask
"canonical" -> "Canonical"

https://codereview.appspot.com/6909046/diff/1/docs/process.rst
File docs/process.rst (right):

https://codereview.appspot.com/6909046/diff/1/docs/process.rst#newcode119
docs/process.rst:119: work. Go to the #launchpad-ops channel on the
canonical IRC server and ask
"canonical" -> "Canonical"

https://codereview.appspot.com/6909046/diff/1/docs/process.rst#newcode177
docs/process.rst:177: work. Go to the #launchpad-ops channel on the
canonical IRC server and ask
"canonical" -> "Canonical"

https://codereview.appspot.com/6909046/

-- 
https://code.launchpad.net/~benji/juju-gui/bug-1083618/+merge/138740
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~benji/juju-gui/bug-1083618 into lp:juju-gui.


References