← Back to team overview

yellow team mailing list archive

Re: Add the ability to rebuild the undocumented file. (issue 6867080)

 

LGTM, there is a minor, but I don't feel strongly.


https://codereview.appspot.com/6867080/diff/1/bin/lint-yuidoc
File bin/lint-yuidoc (right):

https://codereview.appspot.com/6867080/diff/1/bin/lint-yuidoc#newcode114
bin/lint-yuidoc:114: new_style_regex = re.compile('([^:]+):[^ ]+
"([^"]+)"')
minor: Should this use \d+ for the lineno? A little more robust?

https://codereview.appspot.com/6867080/

-- 
https://code.launchpad.net/~benji/juju-gui/yuidoc-forgiveness/+merge/138819
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~benji/juju-gui/yuidoc-forgiveness into lp:juju-gui.


References