yellow team mailing list archive

[Francesco Banconi <francesco.banconi@xxxxxxxxxxxxx>]

Reviewers: mp+139526_code.launchpad.net,

Message:
Please take a look.

Description:
Add support for jitsu deploy-to.

The charm already worked well when deployed in the bootstrap node using
the 'jitsu deploy-to' command. This branch adds a test for this
behavior.

Other changes:

Slightly simplified how the staging option is retrieved in the start
hook.

Fixed tests by changing the juju-gui upstart configuration file. Before
this change it was not possible for upstart to correctly stop the
juju-gui
service, because upstart itself was not able to keep track of the PID.

Fixed the install hook: it was not idempotent (and the tests were broken
for this reason too).

https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1086788-jitsu-deploy-to/+merge/139526

(do not edit description out of merge proposal)


Please review this at https://codereview.appspot.com/6929057/

Affected files:
   A [revision details]
   M config/juju-gui.conf.template
   M hooks/install
   M hooks/start
   M tests/deploy.test
   M tests/test_utils.py



-- 
https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1086788-jitsu-deploy-to/+merge/139526
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/charms/precise/juju-gui/bug-1086788-jitsu-deploy-to into lp:~juju-gui/charms/precise/juju-gui/trunk.