← Back to team overview

yellow team mailing list archive

[Merge] lp:~frankban/juju-gui/fix-notification-tests into lp:juju-gui

 

The proposal to merge lp:~frankban/juju-gui/fix-notification-tests into lp:juju-gui has been updated.

Description changed to:

Restored notifications tests.

This branch restores the tests previously skipped
(as a consequence of the topology refactor) in
``test_application_notifications``.

Simplified the way the number of notifications is 
tested: now, rather than checking a value in the DOM, 
we check how many model instances are present in
the notifications model list.

Also added a test for the notifications view, that was
no longer exercised due to the change described above.

https://codereview.appspot.com/6942045/


For more details, see:
https://code.launchpad.net/~frankban/juju-gui/fix-notification-tests/+merge/139677
-- 
https://code.launchpad.net/~frankban/juju-gui/fix-notification-tests/+merge/139677
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/fix-notification-tests into lp:juju-gui.


References