← Back to team overview

yellow team mailing list archive

Re: Fix GUI breakage on browser resizing. (issue 6941053)

 

Thanks,

This is a nice catch, a good fix and glad to see the additional tests.

+1 LGTM


https://codereview.appspot.com/6941053/diff/1/app/assets/javascripts/d3-components.js
File app/assets/javascripts/d3-components.js (right):

https://codereview.appspot.com/6941053/diff/1/app/assets/javascripts/d3-components.js#newcode238
app/assets/javascripts/d3-components.js:238: var callback =
Y.bind(handler.callback, handler.context);
This is a nice fix, thank you.

https://codereview.appspot.com/6941053/

-- 
https://code.launchpad.net/~frankban/juju-gui/bug-1090046-resize/+merge/139959
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/bug-1090046-resize into lp:juju-gui.


References