yellow team mailing list archive

[Matthew Scott <matthew.scott@xxxxxxxxxxxxx>]

LGTM with a few minors.

Thanks for the update, and handling the questions on IRC.


https://codereview.appspot.com/6945058/diff/1/HACKING.txt
File HACKING.txt (right):

https://codereview.appspot.com/6945058/diff/1/HACKING.txt#newcode98
HACKING.txt:98: Unfortunately, we have not found LXC-based Juju
environments to be reliable
Two paragraphs in a row starting with the same word is a little awkward;
I think the 'Unfortunately' in the second paragraph may be unnecessary
("Currently, running...is quite slow, however, ...")

https://codereview.appspot.com/6945058/diff/1/README.txt
File README.txt (right):

https://codereview.appspot.com/6945058/diff/1/README.txt#newcode73
README.txt:73: when run withing the charm, the GUI appears to not be
connecting properly to
s/withing/within

https://codereview.appspot.com/6945058/

-- 
https://code.launchpad.net/~gary/charms/precise/juju-gui/trunk/+merge/139968
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~gary/charms/precise/juju-gui/trunk into lp:~juju-gui/charms/precise/juju-gui/trunk.