← Back to team overview

yellow team mailing list archive

Re: Update documentation (issue 6945058)

 

Land with changes.

This branch looks good Gary, thanks for these documentation improvements
and clean up.
Just some minor comments follow.



https://codereview.appspot.com/6945058/diff/1/HACKING.txt
File HACKING.txt (right):

https://codereview.appspot.com/6945058/diff/1/HACKING.txt#newcode19
HACKING.txt:19: `getting started
<https://juju.ubuntu.com/docs/getting-started.html>`. If you
Missing underscore at the end of the rst link.

https://codereview.appspot.com/6945058/diff/1/README.txt
File README.txt (right):

https://codereview.appspot.com/6945058/diff/1/README.txt#newcode15
README.txt:15: First, there is no security.  Anyone who can connect to
your machines can
Thanks for adding this warning.

https://codereview.appspot.com/6945058/diff/1/README.txt#newcode40
README.txt:40: $ juju deploy cs:~juju-gui/precise/juju-gui
Should this be a code block?

https://codereview.appspot.com/6945058/diff/1/README.txt#newcode49
README.txt:49: $ watch juju status
Same as above.

https://codereview.appspot.com/6945058/diff/1/README.txt#newcode52
README.txt:52: something that looks like this:
We should add another colon here and indent the following juju status
output example, so that rst, considering that a code block, can
correctly compile the file.

https://codereview.appspot.com/6945058/

-- 
https://code.launchpad.net/~gary/charms/precise/juju-gui/trunk/+merge/139968
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~gary/charms/precise/juju-gui/trunk into lp:~juju-gui/charms/precise/juju-gui/trunk.


References