yellow team mailing list archive

[Nicola Larosa <nicola.larosa@xxxxxxxxxxxxx>]

Also fixed the expose port, thanks.


https://codereview.appspot.com/6940084/diff/1/README.md
File README.md (right):

https://codereview.appspot.com/6940084/diff/1/README.md#newcode60
README.md:60: - 80/tcp
gary.poster wrote:
> I assume this is 443 now?

Indeed, fixed.

https://codereview.appspot.com/6940084/diff/1/hooks/utils.py
File hooks/utils.py (right):

https://codereview.appspot.com/6940084/diff/1/hooks/utils.py#newcode227
hooks/utils.py:227: if not (os.path.exists(pem_path) and
os.path.exists(pem_path)):
gary.poster wrote:
> I suspect you meant key_path for one of those.

Indeed, good catch.

> If only one of the files is there, is it still the right behavior
> to create both files, overwriting them?  I don't know the answer,
> just asking.

I don't really know. I guess better safe than sorry.

https://codereview.appspot.com/6940084/

-- 
https://code.launchpad.net/~teknico/charms/precise/juju-gui/serve-via-https/+merge/140511
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~teknico/charms/precise/juju-gui/serve-via-https into lp:~juju-gui/charms/precise/juju-gui/trunk.