← Back to team overview

yellow team mailing list archive

Re: Serve the GUI assets over HTTPS (issue 6940084)

 

gary.poster wrote:
> Please make a card to add the feature to support supplying a pem
> and key string, as we discussed and as I mentioned in the previous
> review; and make a kanban card for that.

Done.


https://codereview.appspot.com/6940084/diff/13001/tests/deploy.test#newcode56
> tests/deploy.test:56: url = 'http://{0}:{1}'.format(hostname,
self.port)
> This needs to be https in order for the tests to pass.

Done.

> One more thing: please don't forget to increment the value in the
version file

Done.


https://codereview.appspot.com/6940084/

-- 
https://code.launchpad.net/~teknico/charms/precise/juju-gui/serve-via-https/+merge/140511
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~teknico/charms/precise/juju-gui/serve-via-https into lp:~juju-gui/charms/precise/juju-gui/trunk.


Follow ups

References