yellow team mailing list archive

[Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>]

*** Submitted:

Panzoom Module

This branch breaks out the first module
from Mega into a more module unit. While this
module is small a number of changes occur to make
this happen. The framework underwent some improvemnts,
changes around interaction with App and view replacement
occured, event bindings had to be updated. A pattern for
cross module event firing was established.

In future modules, the topo/component fires the events and
modules are bubble targets.

R=gary.poster, hazmat
CC=
https://codereview.appspot.com/6971045



https://codereview.appspot.com/6971045/diff/17/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6971045/diff/17/app/views/environment.js#newcode27
app/views/environment.js:27: broadcast: true,
Test again w/o broadcast.

https://codereview.appspot.com/6971045/diff/17/app/views/topology/mega.js
File app/views/topology/mega.js (right):

https://codereview.appspot.com/6971045/diff/17/app/views/topology/mega.js#newcode872
app/views/topology/mega.js:872: self.cursorBox = new
views.BoundingBox();
need new here?

https://codereview.appspot.com/6971045/

-- 
https://code.launchpad.net/~bcsaller/juju-gui/topology-panzoom/+merge/140671
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~bcsaller/juju-gui/topology-panzoom into lp:juju-gui.