yellow team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

Thank you, Francesco and Nicola!


https://codereview.appspot.com/7005044/diff/1/app/modules-debug.js
File app/modules-debug.js (right):

https://codereview.appspot.com/7005044/diff/1/app/modules-debug.js#newcode29
app/modules-debug.js:29: fullpath:
'juju-ui/assets/javascripts/gallery-timer-debug.js'
On 2012/12/21 10:57:51, frankban wrote:
> These three paths need to be absolute (add a slash at the beginning of
each
> one). Otherwise, in test-debug runs, they are searched inside the
/test/ path,
> and a bunch of tests fail.

Thank you!  Fixed.

https://codereview.appspot.com/7005044/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/7005044/diff/1/app/views/utils.js#newcode121
app/views/utils.js:121: debug: noop
On 2012/12/21 10:57:51, frankban wrote:
> Yay! No more errors running test-prod!

:-)

https://codereview.appspot.com/7005044/

-- 
https://code.launchpad.net/~gary/juju-gui/grabbag/+merge/141022
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~gary/juju-gui/grabbag into lp:juju-gui.