← Back to team overview

yellow team mailing list archive

[Merge] lp:~frankban/juju-gui/bug-1095324-external-resources into lp:juju-gui

 

Francesco Banconi has proposed merging lp:~frankban/juju-gui/bug-1095324-external-resources into lp:juju-gui.

Requested reviews:
  Juju GUI Hackers (juju-gui)
Related bugs:
  Bug #1095324 in juju-gui: "The GUI still wants to load external, not secure, sources"
  https://bugs.launchpad.net/juju-gui/+bug/1095324

For more details, see:
https://code.launchpad.net/~frankban/juju-gui/bug-1095324-external-resources/+merge/141874

Avoid loading the last not secure resource

I.e. the Ubuntu font.

https://codereview.appspot.com/7030060/

-- 
https://code.launchpad.net/~frankban/juju-gui/bug-1095324-external-resources/+merge/141874
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/bug-1095324-external-resources into lp:juju-gui.
=== modified file 'app/index.html'
--- app/index.html	2012-12-05 19:52:20 +0000
+++ app/index.html	2013-01-04 09:45:26 +0000
@@ -6,7 +6,7 @@
     <meta name="viewport" content="width=device-width,initial-scale=1.0">
     <meta name="description" content="">
     <meta name="author" content="Juju team">
-    <link href='http://fonts.googleapis.com/css?family=Ubuntu:400,400italic&subset=latin,latin-ext' rel='stylesheet' type='text/css'>
+    <link href='https://fonts.googleapis.com/css?family=Ubuntu:400,400italic&subset=latin,latin-ext' rel='stylesheet' type='text/css'>
     <link rel="shortcut icon" href="/favicon.ico">
     <link rel="stylesheet" href="/juju-ui/assets/combined-css/all-static.css">
     <link rel="stylesheet" href="/juju-ui/assets/juju-gui.css">


Follow ups